Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): Update image tag in helm charts & build and Makefile updates #256

Merged
merged 4 commits into from
Oct 1, 2024
Merged

fix(CI): Update image tag in helm charts & build and Makefile updates #256

merged 4 commits into from
Oct 1, 2024

Conversation

anurag-rajawat
Copy link
Collaborator

Description

This PR embeds build information into binaries and automates image tag updates in the Helm values.yaml file.

Does this PR introduce a breaking change?
No.

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat marked this pull request as draft September 26, 2024 15:54
@anurag-rajawat anurag-rajawat marked this pull request as ready for review September 26, 2024 16:06
@anurag-rajawat
fix(*): Embed build info into binaries
133cf7f 
Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
@anurag-rajawat
chore: Update engines version
cb6147d 
Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
@anurag-rajawat
fix(CI): Add job to update image tag in helm charts
d60458f 
Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
@anurag-rajawat
fix(integration-test): Fix SIB selector
a02a546 
Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
@daemon1024 daemon1024 changed the title fix(CI): Update image tag in helm charts fix(CI): Update image tag in helm charts & build and Makefile updates Oct 1, 2024
@daemon1024 daemon1024 merged commit 820b5de into 5GSEC:main Oct 1, 2024
12 checks passed
@anurag-rajawat anurag-rajawat deleted the fixes branch October 1, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VedRatan VedRatan VedRatan approved these changes

@daemon1024 daemon1024 daemon1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anurag-rajawat @daemon1024 @VedRatan