Skip to content

Conversation

@XWasHere
Copy link
Contributor

this pr adds a small shell that can upload, download and delete files + list and create directories

it also makes a minor change of setting the mime type of directories to application/x-directory

@XWasHere XWasHere marked this pull request as ready for review May 25, 2022 03:38
@XWasHere
Copy link
Contributor Author

ok so i'm sure i look like a massive idiot, but i forgot that i had suggested the mime types for folders change a while ago but it got rejected, and seeing as this change depends on that, i'm going to close this pr.

@XWasHere XWasHere closed this May 25, 2022
@XWasHere
Copy link
Contributor Author

i believe that this should work most of the time without changing the content type, i added a parse_dir function to check if the response is a directory listing. it won't work if it receives a file that looks identical to a directory but i doubt that would be a problem under normal circumstances.

@XWasHere XWasHere reopened this May 26, 2022
@5HT2
Copy link
Owner

5HT2 commented May 27, 2022

I'll take a look at this when I have time, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants