Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry check to mediator #6

Closed
3 tasks done
rmeissner opened this issue Jun 16, 2023 · 0 comments · Fixed by #14
Closed
3 tasks done

Add registry check to mediator #6

rmeissner opened this issue Jun 16, 2023 · 0 comments · Fixed by #14
Assignees
@akshay-ap
Labels
enhancement New feature or request
Milestone
v0.1.0

Comments

@rmeissner
Copy link
Member

rmeissner commented Jun 16, 2023 •
edited by akshay-ap
Loading

  • Make mediator ownable
  • Make it possible to set registry in mediator
  • Call registry when a new module is added to check if it is a supported module
@akshay-ap akshay-ap mentioned this issue Jun 21, 2023
Merged
9 tasks
akshay-ap added a commit that referenced this issue Jun 28, 2023
@akshay-ap
[#6] Make mediator Ownable
82c1d63
akshay-ap added a commit that referenced this issue Jun 28, 2023
@akshay-ap
[#6] Add registry in the Mediator
22d67e3
akshay-ap added a commit that referenced this issue Jun 28, 2023
@akshay-ap
[#6] Rename file ISafeProtocolRegistry.sol to Registry.sol, add test …
940e8cb 
…for enabling modules with registry into consideration
akshay-ap added a commit that referenced this issue Jun 28, 2023
@akshay-ap
[#6] Rename error type, create function modifier for permitted module…
a6d13f4 
…s, tests
@akshay-ap akshay-ap mentioned this issue Jun 28, 2023
Merged
@akshay-ap akshay-ap self-assigned this Jun 28, 2023
@akshay-ap akshay-ap added the enhancement New feature or request label Jun 28, 2023
@akshay-ap akshay-ap added this to the v0.1.0 milestone Jun 28, 2023
akshay-ap added a commit that referenced this issue Jun 28, 2023
@akshay-ap
[#6] Add natspec docstring
0e93629
akshay-ap added a commit that referenced this issue Jul 3, 2023
@akshay-ap
[#6] Merge changes from mediator changes
0e7ac4b
akshay-ap added a commit that referenced this issue Jul 3, 2023
@akshay-ap
[#6] Rename test functions
63bd8fd
akshay-ap added a commit that referenced this issue Jul 4, 2023
@akshay-ap
[#6] Refactor: Create RegsitryManager.sol and inherit it in SafeProto…
ed1de50 
…colMediator
akshay-ap added a commit that referenced this issue Jul 4, 2023
@akshay-ap
[#6] Refactor tests
94d4db1
akshay-ap added a commit that referenced this issue Jul 4, 2023
@akshay-ap
[#6] Move events, error related to registry to RegistryManager.sol
f7b44e0
akshay-ap added a commit that referenced this issue Jul 5, 2023
@akshay-ap
[#6] Make event parameters indexed when registry is changed, move tests
48527f4
akshay-ap added a commit that referenced this issue Jul 6, 2023
@akshay-ap
[#6] Add checks if registry supports valid interfaceId
df2d0f8
akshay-ap added a commit that referenced this issue Jul 6, 2023
@akshay-ap
[#6] Add test for Registry: check if supports interface id 0x01ffc9a7
e064a0f
akshay-ap added a commit that referenced this issue Jul 6, 2023
@akshay-ap
[#6] Add Imports.sol file
fbe44dc
akshay-ap added a commit that referenced this issue Jul 6, 2023
@akshay-ap
[#6] Implement suggestions: Test case changes, fix todos
1f053b4
akshay-ap added a commit that referenced this issue Jul 6, 2023
@akshay-ap
[#6] Pin version of @gnosis.pm/mock-contract to a specific commit
26a7d11
akshay-ap added a commit that referenced this issue Jul 7, 2023
@akshay-ap
[#6] Add test for registry: return false if invalid interfaceId is pa…
44b0747 
…ssed
akshay-ap added a commit that referenced this issue Jul 7, 2023
@akshay-ap
[#6] Registry tests: use staticCalls, add negative test
f4f03a3
akshay-ap added a commit that referenced this issue Jul 7, 2023
@akshay-ap
[#6] Update comment in Guard interface
d32423b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Add registry check to mediator 5afe/safe-core-protocol
2 participants
@rmeissner @akshay-ap