Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moshi adapter for big decimal numbers; Remove factory #49

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

elgatovital
Copy link
Contributor

Closes #48

Changes proposed in this pull request:

  • adapter for big decimal numbers
  • remove factory

@gnosis/mobile-devs

@elgatovital elgatovital requested a review from rmeissner July 22, 2020 10:38
@codecov-commenter
Copy link

Codecov Report

Merging #49 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     60.17%   60.55%   +0.38%     
  Complexity      154      154              
============================================
  Files            55       55              
  Lines          1401     1397       -4     
  Branches        233      233              
============================================
+ Hits            843      846       +3     
+ Misses          440      433       -7     
  Partials        118      118              
Impacted Files Coverage Δ Complexity Δ
...ava/pm/gnosis/common/adapter/moshi/TypeAdapters.kt 94.44% <100.00%> (+30.80%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69334e5...be1318c. Read the comment docs.

@elgatovital elgatovital merged commit 7901f0b into master Jul 22, 2020
@elgatovital elgatovital deleted the feature/moshi_cleanup branch July 22, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigDecimal moshi adapter
3 participants