Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expatriate Support: Prepend phone number with US Country Code +1 #161

Open
ericallam opened this issue May 4, 2017 · 8 comments
Open

Expatriate Support: Prepend phone number with US Country Code +1 #161

ericallam opened this issue May 4, 2017 · 8 comments

Comments

@ericallam
Copy link

Currently when tapping a phone number from outside of the US, the call will not work because the US Country Code +1 is not present. Appending the +1 should happen automatically if the location of the phone is outside the US. Could also investigate just including the +1 for all calls, or including it as a setting.

@nickoneill
Copy link
Member

Thanks @ericallam! We'll be adding this to all numbers shortly.

@subdigital
Copy link
Collaborator

@nickoneill is this being done yet? Do you have an issue to link to on the server repo?

I'm not against adding an option in the iOS app, but would be easier to fix globally.

@subdigital
Copy link
Collaborator

Another thought on this, we might want to not display the "+1-" by default on the call screen, so if we do end up doing this on the server we'll probably strip it out for display only.

@nickoneill
Copy link
Member

We did some prep to add +1 to numbers via the server, it needs to be tested with the existing version of the app before we start rolling it out.

Is there a reason to strip the +1 for display in some cases?

@subdigital
Copy link
Collaborator

subdigital commented Jul 22, 2017 via email

@lazerwalker
Copy link

Hi! Wanted to +1 this (hah).

Happy to contribute a PR if it's helpful, but it sounds like the barrier here is process rather than code needed?

@nickoneill
Copy link
Member

I wonder if it would be weird to keep the display as XXX-XXX-XXXX but have the number dialed include the +1. All numbers from the server don't include the +1 right now, and I'm not sure they should. Is there a situation where we'd have a non-+1 number?

@Abizern
Copy link
Collaborator

Abizern commented Jul 8, 2020

Is this still needed? There are things that can be done around formatting phone numbers with https://github.com/marmelroy/PhoneNumberKit, although that means bringing in another dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants