Updated welcome screen to a newer style #360
Conversation
Updated layout to single screen, updated to be in line with apple standard designs Friendly for dark mode and dynamic text
Switched to grid Adjusted size/color of symbols
|
Adjusted alignment of symbols, made symbols bigger, and adjusted the colors a bit. We could add a little red in the spend 5 minutes symbol, if you like. I removed the period after "Spend 5 minutes, make 5 calls" so it's more consistent with other content. Still ready to go for dark mode, dynamic text, accessibility support (VoiceOver, Voice Control). One small issue I see is that on the iPhone SE, the continue button is a little cut off. Not sure if it's worth adjusting for? I'll include a screen shot of it below. |
Grouped items, updated accessibility labels to make it easier to navigate top portion of dashboard and select a location using VoiceOver.
There was a problem hiding this comment.
Looks great, a few comments to adjust and then feel free to merge.
In the future it would be nice to see unrelated changes like the location header accessibility changes in another small PR. it's easier to review smaller changesets and I certainly don't mind having more PRs to review
| .opacity(subMessageOpacity) | ||
| .gridColumnAlignment(.leading) | ||
| } | ||
| Spacer() |
There was a problem hiding this comment.
Do we need two spacers here?
There was a problem hiding this comment.
For the welcome view to accommodate dynamic text, I wrapped it in a ScrollView. That changes how spacers work, and two spacers gives us good space / drops the button almost to the bottom with default text sizes and a modern phone. This is also why the button gets cut off a bit on the small phone.
Updated layout to single screen, updated to be in line with apple standard designs. Friendly for dark mode and dynamic text. Includes accessibility improvements to work better with VoiceOver and Voice Control.
Partially resolves #331