Remove UIKit code #371
Merged
Remove UIKit code #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
No point in keeping this around as we're pretty close to shipping the new UI. Compiling is a bit faster and we don't have to worry about the switch in the app delegate anymore. We ditched the seeded URL session entirely because it is a deprecated way to mock network data, I added an item in #331 to get the UI tests going again with the new design so we can use it for screenshots as we had previously been doing.
Has the added benefit of compiling with zero warnings, which is the right standard to set for PRs going forward.