Ensure welcome screen shown before menu popover tip #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cselin
commented
Jan 3, 2024
| { | ||
| if #available(iOS 17, *) { | ||
| if showingWelcomeScreen { | ||
| AnyView(self) |
There was a problem hiding this comment.
I spent a good hour trying to debug this method. If I kept the return's, it compiled, but crashed without a helpful debug message which took me a while to track down. Adding AnyView seems to be required once I introduced the additional conditional 🤷🏻♂️
There was a problem hiding this comment.
I ran into this before but didn't figure out how to get it working, AnyView to the rescue!
nickoneill
approved these changes
Jan 4, 2024
| { | ||
| if #available(iOS 17, *) { | ||
| if showingWelcomeScreen { | ||
| AnyView(self) |
There was a problem hiding this comment.
I ran into this before but didn't figure out how to get it working, AnyView to the rescue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where menu popover tip prevents welcome screen from showing first time app is opened.
RPReplay_Final1704300154.mov
Note:
In this fix, we do not show the menu popover tip the first time the app is launched if the welcome screen is shown, but it will be shown subsequent app launches. I had another implementation that showed the tooltip after the welcome screen is shown, but it was buggy and often was delayed and sometimes even showed up on the detail screen when the menu isn't even available.