Heather's fix for outcome button accessibility #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cselin
approved these changes
Jan 8, 2024
| @@ -74,7 +74,7 @@ class Store: ObservableObject { | |||
| state.issueRouter.selectedIssue = nil | |||
| state.issueRouter.path = NavigationPath() | |||
| case let .GoToNext(issue, nextContacts): | |||
| if nextContacts.count > 1 { | |||
| if nextContacts.count >= 1 { | |||
There was a problem hiding this comment.
Looks like I introduced this in my refactor and then verified it with newly added test 🤦🏻♂️, let's update the test to reflect the correct behavior.
| }) | ||
| } | ||
| } | ||
| OutcomesView(outcomes: issue.outcomeModels, report: { outcome in |
There was a problem hiding this comment.
super nit: I wonder if this whole closure can be replaced by a single action dispatch within OutcomesView that then dispatches all applicable other actions within middleware?
|
Updated the test to ensure correctness in the contact flow, agreed on the dispatch change but we can make it in a future PR when changes are closer to the middleware section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented @heathermh's fix for outcome button accessibility, simplified the outcome nav per @cselin's request in #414, and fixed the off-by-one that was preventing the last contact from showing its IssueContactDetail.
Replaces #414, Fixes #413