Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus of script changes and CI #132

Merged
merged 15 commits into from
Jan 2, 2020
Merged

Omnibus of script changes and CI #132

merged 15 commits into from
Jan 2, 2020

Conversation

bagelbits
Copy link
Collaborator

@bagelbits bagelbits commented Jan 2, 2020

Overview

This addresses #127 and #128. As well as a few other things:

  • Drops all of the old scripts which aren't of much use anymore. (I hope I don't regret this later.)
  • Adds a package.json file so we can add linting and testing stuff.
  • Adds eslint along with the JSON plugin
  • Adds a linting command: npm run-script lint
    • This will be useful once a CI gets hooked up.
  • A MongoDB nuke and replace script
    • This will be useful once CD gets hooked up.
  • Adds heroku.yml
    • This will run the nuke and replace script in Heroku. This is for CD on DB changes showing up in the API
  • Adds .travis.yml for Travis CI

Here's a fun image for your troubles

random photo - update me

@bagelbits bagelbits changed the title [WIP] Omnibus of script changes Omnibus of script changes and CI Jan 2, 2020
@bagelbits bagelbits merged commit 2af468c into master Jan 2, 2020
@bagelbits bagelbits deleted the bagelbits.npm-cleanup branch January 2, 2020 16:50
"description": "Database for 5e-srd-api",
"scripts": {
"lint": "eslint . --ext .js,.json",
"nuke-and-replace-db": "./scripts/nuke-and-replace-db.sh"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be something like:

db:refresh

as tasks grow its handy to namespace/keep them easy to remember.

@benjaminapetersen
Copy link

Looks good, just 2 suggestions:

  • naming scheme for tasks
  • squash commits (all travis stuff into 1 commit, unless it makes sense to keep separate)

@bagelbits
Copy link
Collaborator Author

Well. The commits got squashed when I merged in. Though I could have separated this into at least two PRs. smacks own knucles

I'll open a quick PR that changes the naming for that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants