Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appointment): add calculated and base start/end-date #176 #177

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

DumbergerL
Copy link
Contributor

No description provided.

@DumbergerL DumbergerL force-pushed the feat/176/base-calculated-end-and-start-date branch from 9b4d8e4 to d44154a Compare November 2, 2023 15:24
@DumbergerL
Copy link
Contributor Author

@a-schild What are your thoughts on this proposed solution for issue #176? The "StartDate" and "EndDate" values are now exclusively determined by the "base" and "calculated" properties.

@a-schild
Copy link
Contributor

a-schild commented Nov 3, 2023

Looks fine for me.
I also think it's the most intuitive solution, even when it does not exaclty match the structure as resturned by CT.

DumbergerL added a commit that referenced this pull request Nov 3, 2023
@DumbergerL DumbergerL force-pushed the feat/176/base-calculated-end-and-start-date branch from 780ce0e to 5b0c1f9 Compare November 3, 2023 08:24
@DumbergerL DumbergerL merged commit 7e45ca4 into master Nov 3, 2023
6 checks passed
@DumbergerL DumbergerL deleted the feat/176/base-calculated-end-and-start-date branch November 3, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants