Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for base64 embeddings #190

Merged
merged 5 commits into from
Mar 16, 2024
Merged

add support for base64 embeddings #190

merged 5 commits into from
Mar 16, 2024

Conversation

adri1wald
Copy link
Contributor

@adri1wald adri1wald commented Feb 8, 2024 •
edited
Loading

Resolves #189

Considerations:

  • Instead of using a generic could copy pasta the whole response struct for Base64 embeddings. This was less code, but leaks some implementation details out of the crate.
  • Left the debug assert in - lmk if you want it removed
  • Open to any other suggestions :)

@adri1wald adri1wald force-pushed the feat/base64-embedding-support branch from 6013aed to 9496f22 Compare February 8, 2024 09:48
@64bit
Copy link
Owner

64bit commented Feb 10, 2024

Thank you for the PR!

Looking at the spec doesn't distinguishes base64 response - it opens up implementation details - which you have done nicely!

I'll leave the comments about your considerations separately.

@adri1wald adri1wald force-pushed the feat/base64-embedding-support branch from aafaa27 to d6cd3cd Compare March 13, 2024 18:52
@adri1wald adri1wald requested a review from 64bit March 13, 2024 18:52
@adri1wald
Copy link
Contributor Author

@64bit Sorry about the delay. I think this is ready for another review now! Let me know what you think :)

64bit
64bit approved these changes Mar 16, 2024
View reviewed changes
Copy link
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! thank you for the updates and including tests!

@64bit 64bit merged commit 032f58f into 64bit:main Mar 16, 2024
64bit added a commit that referenced this pull request Apr 10, 2024
@ifsheldon @Strange-Knoll
@64bit @frankfralick @prosammer @dmweis @katya4oyu @xutianyi1999 @sharifhsn @CakeCrusher @vmg-dev @Taoaozw @turingbuilder @GabrielBianconi @sgopalan98 @adri1wald @Gabriel2409 @emk @Sagebati
Sync wasm experiment branch to 0.20 (#213)
580ff11 
* Update to Assistants example (#146)

* Update to Assistants example

* Update examples/assistants/src/main.rs

update api config for consistency and secutity

Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com>

* added assistant creation

* exit, deconstruct assistant, improved readme

---------

Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com>

* Add examples tool-call and tool-call-stream (#153)

* add names (#150)

* Link to openai-func-enums (#152)

* Link to openai-func-enums

* Link to openai-func-enums

* Update async-openai/README.md

---------

Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com>

* In memory files (#154)

* Added ability to use in-memory files (Bytes, vec[u8])

* Removed unnecessary trait impls

* Polished example

* Spec, readme, and crate description updates (#156)

* get latest spec

* update description

* add WASM

* WASM support on experiments branch

* chore: Release

* Make tool choice lower case (#158)

* Fix: post_form to be Sendable (#157)

* changed to allow Send.

* add simple tests for sendable

* fix test name

* chore: Release

* Add support for rustls-webpki-roots (#168)

* Refactor `types` module (#170)

* Document `impl_from!` macro

* Fix up `impl_from!` docs

* Documents `impl_default!` macro

* Document `impl_input!` macro

* Factor out types from `assistants` module in `types`

* Factor out `model`

* Factor out `audio`

* Factor out `image`

* Factor out `file`

* Factor out `fine_tune`

* Factor out `moderation`

* Factor out `edit`

* Factor out `fine_tuning`

* Factor out missed `DeleteModelResponse` into `model`

* Factor out `embedding`

* Factor out `chat`

* Factor out `completion` and eliminate `types`

* Satisfy clippy

---------

Co-authored-by: Sharif Haason <sharif.haason@gmail.com>

* Sync updates from Spec (#171)

* updates to doc comments and types

* deprecated

* update ChatCompletionFunctions to FunctionObject

* More type updates

* add logprobs field

* update from spec

* updated spec

* fixes suggested by cargo clippy

* add query param to list files (#172)

* chore: Release

* Optional model in ModifyAssistantRequest (#174)

All fields (including model) are optional in OpenAI API.

* update contribution guidelines (#182)

* update contribution guidelines

* fix link

* update

* consistency

* Code of conduct

* chore: Release

* fix file test by providing query param

* Added dimensions param to embedding request (#185)

* chore: Release

* fix: CreateTranscriptionRequest language field not convert (#188)

* chore: Release

* Add usage information to the run object (#195)

* Updates from Spec (#196)

* updates from spec

* remove Edits

* remove Fine-Tunes (was deprecated)

* update spec

* cargo fix

* cargo fmt

* chore: Release

* Add Client::build for full customizability during instantiation (#197)

* Change std::sleep to tokio's sleep (#200)

* chore: Release

* add support for base64 embeddings (#190)

* add support for base64 embeddings

* Base64Embedding is an implementation detail

* feat: separate Embeddings::create_base64 method

* chore: use newtype for hosting base64 decoding instead

* chore: remove unused error variant

* Add vision-chat example (#203)

Example matches quickstart from https://platform.openai.com/docs/guides/vision
It showcases struct derived from ChatCompletionRequestMessageContent

* Update Audio APIs from updated spec (#202)

* Implement CreateTranscriptRequest::response_granularities

This PR adds support for `AudioResponseFormat::VerboseJson` and
`TimestampGranularity`, including updated example code. These were
defined as types before, but not fully implemented.

Implements #201.

* Modify transcription API to be more like spec

- Rename `CreateTranscriptionRespose` to `CreateTranscriptionResponseJson` (to match API spec)
- Add `CreateTranscriptionResponseVerboseJson` and `transcribe_verbose_json`
- Add `transcribe_raw` for SRT output
- Add `post_form_raw`
- Update example code

* Upgrade dependencies: Rust crates in Cargo.toml (#204)

* upgrade reqwest

* update reqwest-eventsource

* cargo test working (#207)

* fix: cargo fmt and compiler warnings fixes (#208)

* cargo fmt

* fix imports

* chore: Release

* fixed problems due to code sync

* update worker dependency to resolve build issue

* update test to fix test compilation issue

* add conditional imports

* change default of InputSource and bring back builders of file-related structs

* update doc

---------

Co-authored-by: Gravel Hill <120497873+Strange-Knoll@users.noreply.github.com>
Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com>
Co-authored-by: Frank Fralick <frankfralick@gmail.com>
Co-authored-by: Sam F <43347795+Prosammer@users.noreply.github.com>
Co-authored-by: David Weis <dweis7@gmail.com>
Co-authored-by: yykt <yuuya.yk.katoh@prism.ricoh>
Co-authored-by: XTY <xutianyi1999@live.com>
Co-authored-by: sharif <61516383+sharifhsn@users.noreply.github.com>
Co-authored-by: Sharif Haason <sharif.haason@gmail.com>
Co-authored-by: Sebastian Sosa <37946988+CakeCrusher@users.noreply.github.com>
Co-authored-by: vmg-dev <121135566+vmg-dev@users.noreply.github.com>
Co-authored-by: TAO <38341571+Taoaozw@users.noreply.github.com>
Co-authored-by: turingbuilder <144046780+turingbuilder@users.noreply.github.com>
Co-authored-by: Gabriel Bianconi <1275491+GabrielBianconi@users.noreply.github.com>
Co-authored-by: Santhanagopalan Krishnamoorthy <santhanagopalan.krishnamoorthy@cuanschutz.edu>
Co-authored-by: Adrien Wald <adrien@genei.io>
Co-authored-by: Gabriel <Gabriel2409@users.noreply.github.com>
Co-authored-by: Eric Kidd <git@randomhacks.net>
Co-authored-by: Samuel Batissou Tiburcio <samuelbatissou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64bit 64bit 64bit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedding deserialization error when using encoding_format EncodingFormat::Base64
2 participants
@adri1wald @64bit