Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Content-Length calculation method in CallbackUriNotifier #9

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

tg666
Copy link
Contributor

@tg666 tg666 commented Nov 11, 2023

No description provided.

@tg666 tg666 added the bug Something isn't working label Nov 11, 2023
@jelen07
Copy link

jelen07 commented Nov 13, 2023

Nice catch 👏
Can we add test for it?

- added dev dependencies on `jest`, `nock` and `eslint-plugin-jest`
- added test cases for class `CallbackUriNotifier`
- added GitHub Action
@tg666
Copy link
Contributor Author

tg666 commented Nov 13, 2023

Nice catch 👏 Can we add test for it?

Done 🙂

@tg666 tg666 merged commit 66c001f into main Nov 13, 2023
2 checks passed
@tg666 tg666 deleted the fix/content-length branch November 13, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants