Skip to content

Commit

Permalink
fix: Merge pull request #1 from 6RiverSystems/fix/bigint-built-in
Browse files Browse the repository at this point in the history
fix: recognize bigint as a built-in exception to new-cap
  • Loading branch information
mgabeler-lee-6rs authored Oct 31, 2022
2 parents 10f1edd + bb241fb commit 9171011
Show file tree
Hide file tree
Showing 4 changed files with 103 additions and 25 deletions.
101 changes: 101 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
version: 2.1

orbs:
sixrs-gke: sixriversystems/sixrs-gke@3

jobs:
setup:
docker:
- image: cimg/node:14.17.6
steps:
- checkout
- run:
name: Install Dependencies
command: npm ci
- persist_to_workspace:
root: ./
paths:
- .
# build:
# docker:
# - image: cimg/node:14.17.6
# steps:
# - attach_workspace:
# at: ./
# - run:
# name: Build
# command: npm run only:build
# - persist_to_workspace:
# root: ./
# paths:
# - dist
# lint:
# docker:
# - image: cimg/node:14.17.6
# steps:
# - attach_workspace:
# at: ./
# - run:
# name: check format
# command: npm run format:check
# - run:
# name: Lint
# command: npm run eslint:check -- --format junit --output-file ./reports/eslint/results.xml
# - store_test_results:
# path: ./reports
# - store_artifacts:
# path: ./reports
test:
docker:
- image: cimg/node:14.17.6
environment:
MOCHA_OPTS: --reporter mocha-junit-reporter --reporter-options mochaFile=./reports/junit/mocha/mocha.xml
steps:
- attach_workspace:
at: ./
- run:
name: Unit Tests
command: npm run test
# - run:
# name: Coverage
# command: npm run only:lCov
# - sixrs-gke/codecov
- store_test_results:
path: ./reports
- store_artifacts:
path: ./reports
publish:
docker:
- image: cimg/node:14.17.6
steps:
- attach_workspace:
at: ./
- sixrs-gke/run-release
- sixrs-gke/npm-public-publish
workflows:
version: 2
build-test-deploy:
jobs:
- setup
# - build:
# context: 6rs-public-npm
# requires:
# - setup
# - lint:
# context: 6rs-public-npm
# requires:
# - setup
- test:
context: 6rs-public-npm
requires:
- setup
- publish:
context: 6rs-public-npm
requires:
- setup
# - build
# - lint
- test
filters:
branches:
only: main
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
14.17.6
25 changes: 0 additions & 25 deletions circle.yml

This file was deleted.

1 change: 1 addition & 0 deletions lib/rules/new-cap.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const CAPS_ALLOWED = [
"Error",
"Function",
"Number",
"BigInt",
"Object",
"RegExp",
"String",
Expand Down

0 comments on commit 9171011

Please sign in to comment.