-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck in the grid using keyboard navigation when the cells are not editable #518
Comments
I don't fully understand your problem but just want to mention that SlickGrid was written over 10 years ago (before the first iPhone) so it wasn't created with mobile in mind and most of the events are mouse or keyboard events which might not always work with a mobile phone. If you find where the problem occurs then please create a PR (Pull Request) |
Hey I was googling for something completely different about SlickGrid and felt on this PR that was closed (never merged I think) on the original SlickGrid fork which does mention screen reader, so perhaps it might help with this issue. There's this comment that the user wrote in his PR which mentions screen reader
|
@ghiscoding I would love to see those a11y changes land in this project. Would be glad to help contribute in any way I can. |
@sardell if you find code to fix this issue, we are totally open for any Pull Requests. Perhaps you could clone the 6pac/SlickGrid on your local and try to merge the code from this old PR that I referenced in previous comment. If you that code works, then please do a PR and we'll review it and get it merged. |
@ghiscoding I attempted to merge the code from this PR as you suggested. However, the PR is so old that the merge conflict was essentially two large diffs. Luckily, the PR is small enough that I was able to find where to apply the changes in the current file's state. There are two issues I ran into:
|
- this PR replicates an old SlickGrid PR (except the focus which can cause other issues) mleibman/SlickGrid#616
#976) - this PR replicates an old SlickGrid PR (except the focus which can cause other issues) mleibman/SlickGrid#616
I have an application that implements SlickGrid and we only allow visitors to view the data, just like this example: http://6pac.github.io/SlickGrid/examples/example1-simple.html.
When we did our accessibility testing, we found one could be stuck in the grid using keyboard navigation only because they're just way too many cells. This issue will create even more confusion for screen reader users because the screen reader will not read out the cell value but simply keep silent from cell to cell.
After some research, I figured the best solution is to bypass the table
The text was updated successfully, but these errors were encountered: