Enable Frozen Columns with Column Grouping #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the preheader panel, scroller and spacer elements for the right side panel, and bound scrollLeft to the right panel when frozen columns are set. Exposed the right preheader panel via public getter. Added example of usage.
ghiscoding
reviewed
Aug 30, 2019
ghiscoding
reviewed
Aug 30, 2019
Also renamed the function to get the right preheader panel to be more descriptive. Updated the example to use correct link.
|
Great, looks good to me with the changes 👍 At first I thought this PR was to fix the Row Grouping but it's actually Column (Header/Titles) Grouping. I wonder if that could help in fixing that other Row Grouping bug though 😄 |
|
Ah, yeah, my bad. Forgot to link the issue when I created the PR. |
|
@gavingallagher |
This was referenced Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the preheader panel, scroller and spacer elements for the right side panel, and bound scrollLeft to the right panel when frozen columns are set.
Exposed the right preheader panel via public getter for constructing the column group headers.
Added example of usage.
Fixes #340