feat: remove deprecated DataView methods #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `setAggregators` and `groupBy` were both replaced by `setGrouping` many years ago, so no need to keep these old functions anymore
ghiscoding
added a commit
that referenced
this pull request
Sep 19, 2023
* feat!: major folder restructuring with esbuild to support `iife`, `cjs` and `esm` and soon TypeScript (#804) * feat: migrate all Controls to TypeScript (#808) * feat: migrate all Menu/Buttons Plugins to TypeScript (#811) * feat: migrate all Decorator & Selection Plugins to TypeScript (#812) * feat: migrate CheckboxSelector & State Plugins to TypeScript (#813) * feat: migrate Draggable Grouping Plugins to TypeScript (#814) * feat: migrate Resizer Plugin to TypeScript (#815) * feat: migrate RowMoveManager Plugins to TypeScript (#817) * feat: migrate RowDetail Plugin to TypeScript (#822) * feat: migrate RemoteModel Plugins to TypeScript (#823) * feat: remove deprecated DataView methods (#833) * feat: remove deprecated DataView methods - `setAggregators` and `groupBy` were both replaced by `setGrouping` many years ago, so no need to keep these old functions anymore * feat: add new trading platform high frequency update grid (#835) * feat: add new trading platform high frequency update grid * fix: copying multiple times only kept last undo CellExternalCopyManager - fix an issue where copying and pasting to multiple area only kept the last undo and reapplied it over and over and the cause was because the clipCommand was global to the class so it only kept the last undo, the fix is to make sure the clipCommand variable is local to the execution handler instead --------- Co-authored-by: Nikhil Giddaluru <38428547+nikhil5693@users.noreply.github.com> Co-authored-by: Ben McIntyre <email.ben.mcintyre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setAggregatorsandgroupBywere both replaced bysetGroupingmany years ago, so no need to keep these old functions anymore