Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pageUp/pageDown/home/end to SlickCellSelection, fixes #794 #854

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Oct 1, 2023

  • fixes Allow pageup/pagedown/home/end etc during selection #794
  • adding "pageUp/pageDown/home/end" to SlickCellSelection when using selection with "Shift+{key}"
  • add hasDataView() and getViewportRowCount() methods to SlickGrid and also switch methods getViewportHeight() and getViewportWidth() from protected to public methods
  • add new example-spreadsheet-dataview.html demo to manually test updated Cell Selection feature

TODOs

  • tested manually, it should expect the following:
    • doing pageDown twice then pageUp once should equal to 1 pageDown
    • doing Shift+Home from anywhere should select all cells from current position to first row
    • doing Shift+End from should select all cells from current position to last row
    • using Pagination and doing Shift+{key} should select cells in current page only and not outside of it
  • add new spreadsheet Example to test Cell Selection with Pagination as detailed above
  • add Cypress E2E tests

basic SlickGrid example

brave_jXaDZf7bB1

with DataView & Pagination example

brave_LARcl6SVGz

- fixes #794
- adding "pageUp/pageDown/home/end" to SlickCellSelection when using selection with "Shift+{key}"
- add `hasDataView()` and `getViewportRowCount()` methods to SlickGrid and also make `getViewportHeight()` and `getViewportWidth()` as publish methods
- add new `example-spreadsheet-dataview.html` demo to manually test updated Cell Selection feature
@ghiscoding ghiscoding merged commit f4956e4 into master Oct 3, 2023
2 checks passed
@ghiscoding ghiscoding deleted the feat/cell-selection-page-selection branch October 3, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pageup/pagedown/home/end etc during selection
1 participant