Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subMenuOpenByEvent option to open sub-menus via mouseover #871

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Oct 23, 2023

  • when I implemented sub-menus, I thought it was complex to add open sub-menus via mouseover (not just click event) but it turns out to be quite easy with the latest code that was put in place for sub-menus. So this PR adds the mouseover option and does make it the default event (we have 2 options: click or mouseover and the latter is the default)
  • this new mouseover will be the default but user could change it to work via click event only by changing the option to subMenuOpenByEvent: 'click' (instead of the default which is subMenuOpenByEvent: 'mouseover')

msedge_1t8KcKPjsr

- so I thought it was complex to add open sub-menus via mouseover (not just click event) but it turns out to be quite easy with the latest code I've put in place for sub-menus.
- this new mouseover will be the default but user could change it to only work with a click event by changing `subMenuOpenByEvent: 'click'`
@ghiscoding ghiscoding merged commit 78ea6ae into master Oct 24, 2023
2 checks passed
@ghiscoding ghiscoding deleted the feat/menu-mouseover branch October 24, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants