fix: only allow row drag on cell w/dnd or cell-reorder
#939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a previous PR #897 caused a regression on a cell with a select dropdown (like `Slick.Editors.YesNoSelect`), the regression was caused by the implementation of Draggable `allowDragFromClosest` which will check if current DOM element is `.slick-cell` or if not it will also try its ancestor and that caused the regression because the cell with the editor also had a `.slick-cell` and so the code taught that the user started a drag and it cancelled event bubbling which in turn also prevented the select dropdown to be clickable. - to fix this issue we need to make sure that the cell is queried not just with `div.slick-cell` but also with certain CSS classes, we need to check if it has either `.dnd` or `.cell-reorder` to permit the dragging
- scroll stopped working if we ask for dnd/cell-reorder on the slick cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowDragFromClosestto make.slick-cellor child draggable #898 caused a regression on a cell with a select dropdown (likeSlick.Editors.YesNoSelect), the regression was caused by the implementation of DraggableallowDragFromClosestwhich will check if current DOM element is.slick-cellor if not it will also try its parent and that caused the regression because the cell with the editor also had a.slick-celland so the code taught that the user started a drag and it cancelled event bubbling which in turn also prevented the select dropdown to be clickable.div.slick-cellbut also with certain CSS classes, we need to check if parent has either.dndor.cell-reorderto permit the dragging when checking parent cell withallowDragFromClosest