Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling applyHtmlCode() with number/boolean #942

Merged
merged 1 commit into from
Dec 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/slick.grid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -543,11 +543,18 @@ export class SlickGrid<TData = any, C extends Column<TData> = Column<TData>, O e
return;
}

// apply HTML when enableHtmlRendering is enabled but make sure we do have a value (without a value, it will simply use `textContent` to clear text content)
if (this._options.enableHtmlRendering && val) {
target.innerHTML = this.sanitizeHtmlString(val as string);
let sanitizedText = val;
if (typeof sanitizedText === 'number' || typeof sanitizedText === 'boolean') {
target.textContent = sanitizedText;
} else {
target.textContent = this.sanitizeHtmlString(val as string);
sanitizedText = this.sanitizeHtmlString(val as string);

// apply HTML when enableHtmlRendering is enabled but make sure we do have a value (without a value, it will simply use `textContent` to clear text content)
if (this._options.enableHtmlRendering && sanitizedText) {
target.innerHTML = sanitizedText;
} else {
target.textContent = sanitizedText;
}
}
}
}
Expand Down