Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI V2 #99

Merged
merged 7 commits into from
Nov 2, 2020
Merged

UI V2 #99

merged 7 commits into from
Nov 2, 2020

Conversation

alameenkhader
Copy link
Collaborator

@alameenkhader alameenkhader commented Sep 25, 2020

UI Improvements MVP

@@ -0,0 +1,12 @@
"use strict";

angular.module("apiDocoApp").directive("linkIcon", [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'angular' is not defined.

@@ -0,0 +1,12 @@
"use strict";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the function form of "use strict".

@@ -0,0 +1,13 @@
"use strict";

angular.module("apiDocoApp").directive("copyIcon", [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'angular' is not defined.

@@ -0,0 +1,13 @@
"use strict";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the function form of "use strict".

@@ -0,0 +1,13 @@
"use strict";

angular.module("apiDocoApp").directive("redirectIcon", [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'angular' is not defined.

@@ -0,0 +1,13 @@
"use strict";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the function form of "use strict".

expect(page).to have_text("optional")
expect(page).to have_text("#{param[:type]}")
expect(page).to have_text(param[:key])
expect(page).to have_text("OPTIONAL")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

expect(page).to have_text("required")
expect(page).to have_text("#{param[:type]}")
expect(page).to have_text(param[:key])
expect(page).to have_text("REQUIRED")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

@alameenkhader alameenkhader added this to the release v1.6.2 milestone Nov 2, 2020
@alameenkhader alameenkhader merged commit cdeb2ce into master Nov 2, 2020
@alameenkhader alameenkhader deleted the ui-easy-wins branch November 2, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant