Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Connect to ethcode deploy API (experimental) #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0mkara
Copy link
Member

@0mkara 0mkara commented Mar 4, 2021

No description provided.

@0mkara 0mkara requested review from bunsenstraat and yann300 March 4, 2021 07:36
@0mkara 0mkara self-assigned this Mar 4, 2021
@0mkara 0mkara added the enhancement New feature or request label Mar 4, 2021
@@ -207,6 +207,20 @@ export async function activate(context: ExtensionContext) {
console.log(error);
}
});
// extension connector
commands.registerCommand('rmxPlugins.deploy', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not really against adding a deploy command here,
I think ethcode should listen on compilation result.
e.g it has either a remix plugin layer that will allow to listen using the remix API, or (that would be ok for the moment, ethcodeApi.loadCompiled(compilationResult); can be called each time there's a compilation result coming from remix-plugin).
And I suppose this will be replace later on by a direct connection with Juan Blanco's extension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 different compilers inside remix vscode extension. In future there could be more. And also there is vyper compiler.
We can try to load the compilation results directly from other compiler extensions. I would also love to load it from remix vscode extension.

Yes your idea of having a plugin (may be just another command plugin) to load the compilation results and then call ethcode can be the exact thing we want. Let me try and I will get back to you. 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants