-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1968: locator-private bindings #2162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2162 +/- ##
==========================================
Coverage ? 66.45%
==========================================
Files ? 591
Lines ? 11498
Branches ? 1335
==========================================
Hits ? 7641
Misses ? 3857
Partials ? 0 |
pshirshov
force-pushed
the
feature/1968-private-bindings
branch
from
August 8, 2024 17:34
d050982
to
e0d32e5
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P/R introduces the concept of Locator-private bindings.
Locator-local instances cannot be seen by inherited locators.
There are 3 supported modes:
confined
(the old behavior, kept as the default one)exposed
For bootstrap injectors the default behavior is (3). Also, from now on the bootstrap planning uses predefined set of roots instead of
Roots.Everything
, so bootstrap context are subjected to garbage colleciton.THIS CHANGE IS INCOMPATIBLE WITH PREVIOUS VERSIONS and requires manual intervention if you have any custom bootstrap modules in your code.
All the bootstrap entities which you need to be available in the downstream locators, must be explicitly marked as
exposed
. There is no way to define GC roots for the bootstrap injector, so it considers all theexposed
entities in bootstrap modules to be roots.