Add types for path imports #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to reduce vite bundled size. Here I suggest to allow importing from paths to prevent bundling everything when only one class is used. Treeshaking here doesn't work because of the way code is written.
7rulnik
approved these changes
Jan 18, 2022
TrySound
added a commit
to TrySound/vite
that referenced
this pull request
Jan 18, 2022
source-map-js is a js fork with applied optimisations comparable with rust optimisation in latest source-map versions. Staying on js allows us to bundle package and not increase install size. As a bonus I added support for importing from lib directly so we could avoid bundling whole package. See 7rulnik/source-map-js#13 ``` du -ck dist/node ``` before: 4164 kB after: 4140 kB
9 tasks
TrySound
added a commit
to TrySound/vite
that referenced
this pull request
Jan 18, 2022
source-map-js is a js fork with applied optimisations comparable with rust optimisation in latest source-map versions. Staying on js allows us to bundle package and not increase install size. As a bonus I added support for importing from lib directly so we could avoid bundling whole package. See 7rulnik/source-map-js#13 ``` du -ck dist/node ``` before: 4164 kB after: 4140 kB
patak-dev
pushed a commit
to vitejs/vite
that referenced
this pull request
Jan 18, 2022
source-map-js is a js fork with applied optimisations comparable with rust optimisation in latest source-map versions. Staying on js allows us to bundle package and not increase install size. As a bonus I added support for importing from lib directly so we could avoid bundling whole package. See 7rulnik/source-map-js#13 ``` du -ck dist/node ``` before: 4164 kB after: 4140 kB
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Feb 12, 2022
source-map-js is a js fork with applied optimisations comparable with rust optimisation in latest source-map versions. Staying on js allows us to bundle package and not increase install size. As a bonus I added support for importing from lib directly so we could avoid bundling whole package. See 7rulnik/source-map-js#13 ``` du -ck dist/node ``` before: 4164 kB after: 4140 kB
andersk
reviewed
Mar 6, 2023
| file?: string; | ||
| sourceRoot?: string; | ||
| } | ||
| declare module 'source-map-js' { |
There was a problem hiding this comment.
The declare module syntax is only for stubbing third-party modules. To declare modules in the current package, you should just write a separate .d.ts file for each .js file. This fixes TS2306 “File …/source-map.d.ts is not a module” errors.
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to reduce vite bundled size. Here I suggest to allow
importing from paths to prevent bundling everything when only one class
is used. Treeshaking here doesn't work because of the way code is written.
Note: review with hidden whitespaces