Fix resetAnkiDroidDirectory signature to restore backward compatibility#4
Draft
Copilot wants to merge 3 commits intofix/startup-crash-null-19652from
Draft
Fix resetAnkiDroidDirectory signature to restore backward compatibility#4Copilot wants to merge 3 commits intofix/startup-crash-null-19652from
Copilot wants to merge 3 commits intofix/startup-crash-null-19652from
Conversation
5 tasks
…ameter Co-authored-by: 7se7en72025 <218611947+7se7en72025@users.noreply.github.com>
Co-authored-by: 7se7en72025 <218611947+7se7en72025@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on graceful fallback for external storage
Fix resetAnkiDroidDirectory signature to restore backward compatibility
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The
resetAnkiDroidDirectorymethod signature was changed in PR #2, removing the optionaldirectoryparameter. This broke the call inDatabaseErrorDialog.kt:527which passes two arguments.Fixes
Approach
Restored the original method signature with the optional
directoryparameter:This allows both calling patterns:
resetAnkiDroidDirectory(context)— uses default directoryresetAnkiDroidDirectory(context, directory)— uses specified directory (as used byDatabaseErrorDialog.kt)How Has This Been Tested?
Code review verified the signature matches both the original implementation and existing call sites.
Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.