Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Update sensor.py to include optional Air Quality Sensors #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcattle
Copy link

@mcattle mcattle commented Nov 24, 2023

If the Kidde Smoke + CO detector also includes the Air Quality Monitor feature, additional entities will be created to measure the various air quality values. These measurement entities also have a "Status" attribute that includes the Kidde summary of the value as "Good", "Moderate", and such.

If the Kidde Smoke + CO detector also includes the Air Quality Monitor feature, additional entities will be created to measure the various air quality values.  These entities also have a "Status" attribute that includes the Kidde summary of the value as "Good", "Moderate", and such.
@dandanio
Copy link

That would be an awesome update.

@GiveMeTheBits
Copy link

Adding my vote to get this approved. the IAQ data is what I am most interested in gathering via Home Assistant.

@alloveru
Copy link

great addition!
good work to you both!

@fixthisbuildthat
Copy link

Also would love the temp and humidity data. whole reason I wanted to add these to HA. Thanks!

@mcattle
Copy link
Author

mcattle commented Jan 15, 2024

@865charlesw Would you mind reviewing this PR and merging it?

@emmarichardson
Copy link

Did you add more changes in your repo @mcattle - I tried switching out the sensor.py file with the one from your repo but HomeAssistant errored out on restart (on that integration only)...said it couldn't load the config so I am guessing that maybe you have added some more changes in your repo and I would have to install from scratch with yours?

@mcattle
Copy link
Author

mcattle commented Jan 16, 2024

Did you add more changes in your repo @mcattle - I tried switching out the sensor.py file with the one from your repo but HomeAssistant errored out on restart (on that integration only)...said it couldn't load the config so I am guessing that maybe you have added some more changes in your repo and I would have to install from scratch with yours?

No, I'm pretty sure my only changes are to that one file. Could you post your error log so that I may take a look?

@emmarichardson
Copy link

Screenshot 2024-01-17 at 7 32 15 AM Sorry to post that way but was having issues copying and pasting

@mcattle
Copy link
Author

mcattle commented Jan 17, 2024

@emmarichardson I think you copied too much into that file. Your sensor.py should contain just this: sensor.py

@tankdeer
Copy link

@mcattle not trying to volunteer you, but have you considered forking this repo and running with it a little more? It seems like @865charlesw might be MIA, and hasn't shown any activity since mid November. I know there are plenty of people interested in this

@mcattle
Copy link
Author

mcattle commented Jan 17, 2024

@mcattle not trying to volunteer you, but have you considered forking this repo and running with it a little more? It seems like @865charlesw might be MIA, and hasn't shown any activity since mid November. I know there are plenty of people interested in this

I'm not a Python dev, though, I'm a C# dev. I can fiddle enough to add a couple sensors, but I can't add support for firmware upgrade detection and installation, which is a feature I also want. @865charlesw did mention that his last push was "before he left", but I don't know to where or for how long. I'm hoping he'll turn up soon.

@tankdeer
Copy link

@mcattle not trying to volunteer you, but have you considered forking this repo and running with it a little more? It seems like @865charlesw might be MIA, and hasn't shown any activity since mid November. I know there are plenty of people interested in this

I'm not a Python dev, though, I'm a C# dev. I can fiddle enough to add a couple sensors, but I can't add support for firmware upgrade detection and installation, which is a feature I also want. @865charlesw did mention that his last push was "before he left", but I don't know to where or for how long. I'm hoping he'll turn up soon.

Entirely reasonable. I am not great with Python myself. Fingers crossed he shows up and this integration is not DOA

@emmarichardson
Copy link

@mcattle I literally did a wget on the file from your repo after moving the old one...

@mcattle
Copy link
Author

mcattle commented Jan 17, 2024

@mcattle I literally did a wget on the file from your repo after moving the old one...

It appears that you did a wget of the HTML page, as opposed to the raw file.

@mcattle
Copy link
Author

mcattle commented Mar 11, 2024

@865charlesw Any chance on getting this PR merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants