fix: Implement missing recursive is_cachable() for Expr::Localize
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote from https://projectfluent.org/fluent/guide/hello.html ```ftl hello = Hello, world! ``` Each message has an identifier that allows the developer to bind it to the place in the software where it will be used. The above message is called `hello`.
|
@11Tuvork28 Can be merged |
|
Thanks again for the work you're putting into this, highly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Implement missing recursive is_cachable() for Expr::Localize
Check recursively if
Expr::Localizeis cacheable.Rationale:
Lookup is static and reproducible and thus cachable for each set of
text_idand arguments.Therefore,
localize()exprs are cachable whenever their input is cachable.fix(style): Name localization message identifier as in Fluent Project
Quote from https://projectfluent.org/fluent/guide/hello.html
Each message has an identifier that allows the developer to bind it to the place in the software where it will be used. The above message is called
hello.fix(style): Normalize test names, prefix all with test_
Bring names of
i18ntests in line with all other tests, by prefixingtest_: