feat: add envfrom into deployments to enable loading entire secrets o…

…r configMaps into container ENV_VARs Signed-off-by: Marcel Dias <marcel@pltf.dev>
8gears · Jul 16, 2024 · c22f1b1 · c22f1b1
1 parent d10683b
commit c22f1b1
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/charts/n8n/templates/deployment.webhooks.yaml b/charts/n8n/templates/deployment.webhooks.yaml
@@ -56,6 +56,10 @@ spec:
           args: ["webhook"]
           env:
             {{- include "n8n.deploymentPodEnvironments" . | nindent 12 }}
+          {{- with .Values.envFrom }}
+          envFrom:
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
           ports:
             - name: http
               containerPort: {{ get .Values.config "port" | default 5678 }}

diff --git a/charts/n8n/templates/deployment.worker.yaml b/charts/n8n/templates/deployment.worker.yaml
@@ -56,6 +56,10 @@ spec:
           args: ["worker", "--concurrency={{ .Values.scaling.worker.concurrency }}"]
           env:
             {{- include "n8n.deploymentPodEnvironments" . | nindent 12 }}
+          {{- with .Values.envFrom }}
+          envFrom:
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
           ports:
             - name: http
               containerPort: {{ get .Values.config "port" | default 5678 }}

diff --git a/charts/n8n/templates/deployment.yaml b/charts/n8n/templates/deployment.yaml
@@ -67,6 +67,10 @@ spec:
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
             {{- include "n8n.deploymentPodEnvironments" . | nindent 12 }}
+          {{- with .Values.envFrom }}
+          envFrom:
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
           lifecycle:
             {{- toYaml .Values.lifecycle | nindent 12 }}
           ports:

diff --git a/charts/n8n/values.yaml b/charts/n8n/values.yaml
@@ -116,6 +116,10 @@ extraEnvSecrets: {}
 #     name: postgres-user-auth
 #     key: password
 
+envFrom: []
+  # - secretRef:
+  #     name: secret-name
+
 ## Common Kubernetes Config Settings
 persistence:
   ## If true, use a Persistent Volume Claim, If false, use emptyDir