Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EightPointsGuzzleBundlePlugin to follow PSR #272

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Rename EightPointsGuzzleBundlePlugin to follow PSR #272

merged 1 commit into from
Oct 10, 2019

Conversation

gregurco
Copy link
Member

@gregurco gregurco commented Oct 8, 2019

Q A
Bug fix no
New feature no
BC breaks yes
Deprecations no
Tests pass yes
Fixed tickets #178
License MIT

@florianpreusner what do you think about PluginInterface instead of long EightPointsGuzzleBundlePluginInterface?

florianpreusner
florianpreusner approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it more than before 👍
Don't why it was different, I think there was a guideline somewhere. But since we have the namespace it much better to keep it short.

@gregurco gregurco merged commit b5080c9 into 8p:master Oct 10, 2019
@gregurco gregurco deleted the fix_178 branch October 10, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianpreusner florianpreusner florianpreusner approved these changes

Assignees

@gregurco gregurco

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregurco @florianpreusner