Split events v7 #287
Merged
Split events v7 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony 4.4 doesn't ship with tests anymore as of version 4.4, so we're not able to use their logger for testing this bundle against 4.4. With our own Logger for the tests we can test against Symfony 4.4 again.
There will be a lot of tests added to this class over the following commits, and it would benefit the readability of the class as a whole if it is cleaned up a bit.
Instead of listening to all pre transaction events and filtering for a desired service name, clients can not also listen for events from specific clients.
Instead of listening to all post transaction events and filtering for a desired service name, clients can not also listen for events from specific clients.
gregurco
requested changes
Dec 26, 2019
gregurco
reviewed
Dec 26, 2019
rpkamp
force-pushed
the
split-events-v7
branch
from
89a9a16 to
27c7f56
Compare
|
All feedback processed, @gregurco 🙂 |
|
@florianpreusner please check this one too 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add functionality introduced in #284, but based against version 7 of this bundle, including deprecation notices.