Replace poetry dev group name #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Kirade
requested changes
Feb 6, 2024
.gitignore
Outdated
| @@ -191,7 +191,7 @@ ipython_config.py | |||
| # This is especially recommended for binary packages to ensure reproducibility, and is more | |||
| # commonly ignored for libraries. | |||
| # https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control | |||
| #poetry.lock | |||
| poetry.lock | |||
There was a problem hiding this comment.
Would you split this part into another PR?
This is not related to linked issue.
There was a problem hiding this comment.
This is a correct suggestion! Since changing the poetry group name modifies the poetry.lock file, we should first merge the PR that adds poetry.lock to .gitignore.
Kirade
previously approved these changes
Feb 8, 2024
Kirade
force-pushed
the
feature/29-rename-poetry-group
branch
from
0811e8e
to
a0bd4da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
package.toml.Ref
resolve #29