Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #123

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Localization #123

wants to merge 46 commits into from

Conversation

Genora51
Copy link
Member

@Genora51 Genora51 commented Sep 22, 2020

This pull request replaces #14 and includes more recent commits to the repo.

Work that still needs to be done before this can be merged:

  • Fixing some visual differences between this and master.
  • Fixing and checking translations of updated questions:
    • French (no questions?)
    • Spanish
    • German
    • Japanese
    • Turkish
    • Portuguese
  • Some other assorted tweaks of the l10n system to make it easier to edit and update questions.

gervasiocaj and others added 30 commits April 23, 2017 21:29
Uses the i18next framework.

Resolves #5
Progress of adaptation:
- [x] Questions
- [x] Quiz
- [ ] Index
- [ ] Instructions
- [ ] Results
    Progress of adaptation:
    - [x] Questions
    - [x] Quiz
    - [x] Index
    - [x] Instructions
    - [ ] Results
Progress of adaptation:
  - [x] Questions
  - [x] Quiz
  - [x] Index
  - [x] Instructions
  - [x] Results
In order to load the namespaces and do the string binding, just load the i18n.js file on the HTML and call the i18n_load_ns with the namespaces notation found [here](http://i18next.com/translate/namespace/).
To fill the string data (e.g. "12 apples), the element must adhere to the following notation (see HTML data-* attributes):

```html
<p data-i18n="apple_count" data-amount="18"></p>
```
```json
{ "apple_count": "{{amount}} apples" }
```

To refresh the string, alter the data-* attribute accordingly and call `i18n_ready()`.
…lation

Corrections according to the ortographic agreement and changes on the master branch
To localize images, add the file-[lng].svg to the value_images/ diretory and add an entry on the corresponding translation.json:

    "file.svg": "file-[lng].svg"
Added comments to `i18n.js` on how to block unfinished translations from being published
Translation of the remaining questions
@KebabLord
Copy link

don't let the project die @gervasiocaj

@ghost
Copy link

ghost commented Feb 20, 2021

Hi, I made a Japanese translation.
(I'm a GitHub newbie, I hope this is an acceptable way to make a contribution...sorry in advance)

ja.zip

@Genora51
Copy link
Member Author

Hey @choux-kasa, that looks great! I'll look into adding these into my fork of the project to check it's all OK. In future I'd suggest learning to use git, because it makes the process a lot easier, but thanks for the translation.

@doamatto
Copy link
Contributor

This PR should be linked with the following issues so that they can be auto-closed on merge: #61 #39 and #5

@doamatto
Copy link
Contributor

I can contribute FR-FR locales

This was referenced Mar 10, 2021
@doamatto
Copy link
Contributor

Hi, I made a Japanese translation.
(I'm a GitHub newbie, I hope this is an acceptable way to make a contribution...sorry in advance)

ja.zip

I added this to #136 as well

KebabLord and others added 3 commits March 14, 2021 12:34
Co-authored-by: Guillaume de Sagazan <guillaume@desagazan.fr>
Add French and Japanese locales
@piotr-yuxuan
Copy link

Hello, popping out randomly; any way for the general public to assist the maintainers in getting this merged? :-)

@Genora51
Copy link
Member Author

Absolutely! You can fork the project and contribute translations via a pull request into the localization branch (see #136).

If you're less well-versed in git & github, then feel free to post your translation here in this comment section and either me or one of the other lovely people who contribute to the project will get round to applying it to the codebase! 😄

@piotr-yuxuan
Copy link

piotr-yuxuan commented Apr 1, 2021

Thank you for your nice, inclusive reply. I think I can manage git and GitHub, and the language I can translate is aready baked into this PR, so I was wondering what I could do to ease the path of this PR. I'll try to resolve merge conflicts :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants