Feat: Room + User metadata + Audio level indication (X is speaking)

[jibon57]

First of thanks for the excellent project!!

I was going through the code & did not find option for user metadata. Although I saw room metadata but from JS SDK default option set to undefined. I think room & user metadata both are important option to have. Also option to update those info & send event on update to every connected user. You can consider this during your development.

Audio level indication will be another feature to have by this way UI can be updated based on the current talking user.

Thank you!

[giangndm]

@jibon57 yes, metadata is very important for integrating with other system or in UI/UX. I will check if it easy to implement I will do it next week.

[jibon57]

Thanks @giangndm that's excellent. But do you think updating/adding that from client side will be safe? Because in metadata may contain certain secret info. I still prefer to manage those from sever level API. Having client side is Ok but need to ensure that user can't manage it my themselves as token will be always visible.

[jibon57]

At least room metadata should not be updated/added from client side.

[giangndm]

@jibon57 Oh, I see. So we need a other level of metadata, which should generated belong with join token. It only need some small change so I am going to implement it next week.

[jibon57]

Perfect! Thanks

[jibon57]

Another issue, at present by joining the session room are creating which have one security issue. For example ttl of token is 1 hour & after 30 minutes admin had ended meeting but as the token can be reused and any user can start new session. This will be hard to manage. Meeting/session should be created my server level API only. Later using token user will be join only with limited authorization. You can think about it. Or at least one option to disable room creation just by joining token. Livekit also have this option which is I think good.

[giangndm]

The question is how we do with metadata, is is necessary to dynamic for allowing client update on-air

[jibon57]

I believe having separate server related API will be best in this case. Same as livekit is doing now

[giangndm]

@jibon57 can you send me the document of livekit about the feature?

[jibon57]

https://docs.livekit.io/realtime/server/generating-tokens/
https://docs.livekit.io/realtime/server/managing-rooms/
https://docs.livekit.io/realtime/server/managing-participants/

[giangndm]

@jibon57 about audio activity, you can check here:

https://github.com/8xFF/atm0s-media-sdk-ts/blob/main/packages/sdk-react-hooks/src/hooks/consumer.tsx
https://github.com/8xFF/atm0s-media-sdk-ts/blob/main/packages/sdk-react-hooks/src/hooks/mixer.tsx

[jibon57]

thanks

[giangndm]

@jibon57 I just merged userdata feature, which is embedded into peer token.

8xFF/atm0s-media-sdk-ts#11
#379

Can you give a try?

[jibon57]

wow!! nice! Do you think the name is bit confusing? Only metadata or roomMetadata or roomExtraData etc could be better? As that's not userData.

[giangndm]

Ohh, I see. because it is peer level then is it peerExtraData make sense? metadata is already used for data set by client.

[jibon57]

Yes, that will nice too.

[giangndm]

I just created PR for rename it to extra_data. It will be merged soon.

8xFF/atm0s-media-sdk-ts#15
#386