Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fefactor: rename userdata to extra data #386

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

giangndm
Copy link
Contributor

Pull Request

Description

This PR rename from peer's userdata to peer's extra_data for avoiding mis-understanding

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 37.14286% with 44 lines in your changes missing coverage. Please review.

Project coverage is 42.81%. Comparing base (a484a4e) to head (652effa).

Files Patch % Lines
bin/src/server/gateway/local_rpc_handler.rs 0.00% 8 Missing ⚠️
packages/media_runner/src/worker.rs 0.00% 6 Missing ⚠️
packages/transport_webrtc/src/transport.rs 0.00% 5 Missing ⚠️
bin/src/http/api_media.rs 0.00% 4 Missing ⚠️
bin/src/http/api_token.rs 0.00% 3 Missing ⚠️
packages/protocol/src/transport/webrtc.rs 0.00% 3 Missing ⚠️
packages/transport_webrtc/src/transport/whep.rs 0.00% 3 Missing ⚠️
packages/transport_webrtc/src/transport/whip.rs 0.00% 3 Missing ⚠️
bin/src/server/media/rpc_handler.rs 0.00% 2 Missing ⚠️
packages/protocol/src/transport/whep.rs 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   42.81%   42.81%           
=======================================
  Files         134      134           
  Lines       14534    14534           
=======================================
  Hits         6223     6223           
  Misses       8311     8311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review July 26, 2024 04:22
@giangndm giangndm merged commit b63e5cf into 8xFF:master Jul 26, 2024
10 of 11 checks passed
@giangndm giangndm mentioned this pull request Jul 31, 2024
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the refactor-rename-userdata-to-extra_data branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant