-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connector external event log - protobuf #132
feat: connector external event log - protobuf #132
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 51.73% 52.78% +1.04%
==========================================
Files 143 146 +3
Lines 11975 12171 +196
==========================================
+ Hits 6195 6424 +229
+ Misses 5780 5747 -33 ☔ View full report in Codecov by Sentry. |
@luongngocminh I have concern about how developer handle received event, which don't have type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix errors
Connector Server now accepts custom
JSON and Protobuf, currently only JSON is ImplementedProtobuf onlyRelated to: #121