Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat ping with node usage #298

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented May 28, 2024

Pull Request

Description

This PR implement node metric feedback mechanism for supporting gateway routing

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

@giangndm giangndm marked this pull request as ready for review May 28, 2024 17:27
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 11.44578% with 294 lines in your changes are missing coverage. Please review.

Project coverage is 41.64%. Comparing base (e856cb8) to head (3612877).

Current head 3612877 differs from pull request most recent head 24f8f32

Please upload reports for the commit 24f8f32 to get more accurate results.

Files Patch % Lines
bin/src/server/gateway/local_rpc_handler.rs 0.00% 151 Missing ⚠️
bin/src/node_metrics.rs 0.00% 41 Missing ⚠️
packages/media_gateway/src/agent_service.rs 0.00% 32 Missing ⚠️
bin/src/server/gateway.rs 0.00% 21 Missing ⚠️
packages/media_runner/src/worker.rs 0.00% 18 Missing ⚠️
bin/src/server/media.rs 0.00% 16 Missing ⚠️
packages/media_gateway/src/store_service.rs 0.00% 10 Missing ⚠️
packages/media_gateway/src/store.rs 90.47% 4 Missing ⚠️
bin/src/server/media/runtime_worker.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   41.84%   41.64%   -0.21%     
==========================================
  Files          84       86       +2     
  Lines        9055     9152      +97     
==========================================
+ Hits         3789     3811      +22     
- Misses       5266     5341      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit bcc13fa into 8xFF:master May 28, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request May 28, 2024
@giangndm giangndm deleted the feat-ping-with-node-usage branch June 6, 2024 00:43
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
* refactor: move gateway http logic to separate part

* feat: collect node metrics to gateway services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant