-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rtp transport for SIP #359
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 42.81% 39.94% -2.87%
==========================================
Files 134 149 +15
Lines 14534 15890 +1356
==========================================
+ Hits 6223 6348 +125
- Misses 8311 9542 +1231 ☔ View full report in Codecov by Sentry. |
You can use local-ip-address lib to get current node IP. May be with sip we only need single default IP
You need transcode it to opus, which is used to send over cluster |
NodeJs sample is moved to separated repo: https://github.com/8xFF/atm0s-media-sip-call-sample |
* add rtp engine for voip * add answer offer sdp with fixed * create rtp internal process for transport * add rtp parser packet * rewrite sdp answer function * add sample for sip drachtio * add simple converter * refactor ng-controller-server * first working without transcode * fixed warns * fix deny with sdp-rs * fix deny with sdp-rs * added token secure * added gateway proxy * audio transcode * fix warns * fix typos * update github action * add SIP docs --------- Co-authored-by: Giang Minh <giang.ndm@gmail.com>
Pull Request
Description
I added the RTP transport for the SIP call—it is a transport for processing the raw RTP packet without Webrtc. I also added a server using the ng-control protocol, such as an RTP engine, for request calling from the SIP server.
Checklist
Additional Notes
Some problems I faced:
I generate the answer SDP by fixing the media session and using the public IP of the current node. But I think it is another way to generate a more generic SDP
For the transmitted RTP packet flow, I will convert the UDP data to an RTP packet and send it to the Media Endpoint. Is my way okay?