Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: switched to internal deps from crate.io #367

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

giangndm
Copy link
Contributor

Pull Request

Description

This PR switch internal deps (atm0s-sdn and sans-io-runtime) from git to crates.io

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

@giangndm giangndm marked this pull request as ready for review July 22, 2024 10:43
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 41.67%. Comparing base (4f88848) to head (7b5f4e5).

Files Patch % Lines
packages/media_runner/src/worker.rs 0.00% 36 Missing ⚠️
bin/src/main.rs 0.00% 14 Missing ⚠️
bin/src/server/connector.rs 0.00% 1 Missing ⚠️
bin/src/server/console.rs 0.00% 1 Missing ⚠️
bin/src/server/gateway.rs 0.00% 1 Missing ⚠️
bin/src/server/media/runtime_worker.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   41.77%   41.67%   -0.11%     
==========================================
  Files         134      134              
  Lines       14274    14310      +36     
==========================================
  Hits         5963     5963              
- Misses       8311     8347      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit 98f938e into 8xFF:master Jul 22, 2024
9 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the switch-internal-deps-to-crates branch November 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant