Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: firefox webrtc don't work with channel id 1000, switch back to 0 #402

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Jul 31, 2024

Pull Request

Description

This PR fixed connect error with Firefox, it only works after 8xFF/atm0s-media-sdk-ts#18 is merged

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.94%. Comparing base (69d6752) to head (7c60a42).

Files Patch % Lines
packages/transport_webrtc/src/transport.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   39.94%   39.94%   -0.01%     
==========================================
  Files         149      149              
  Lines       15890    15893       +3     
==========================================
  Hits         6348     6348              
- Misses       9542     9545       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review July 31, 2024 11:32
@giangndm giangndm linked an issue Jul 31, 2024 that may be closed by this pull request
@giangndm giangndm merged commit 44824dd into 8xFF:master Jul 31, 2024
9 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the fix-firefox-no-video branch November 26, 2024 17:19
This was referenced Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: not working with firefox
1 participant