Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: missing config connector agent service which caused missing peer logs #405

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Aug 7, 2024

Pull Request

Description

This PR fixed missing peer logs issue.
The main reason is config for connector agent is only set for controller thread, not worker thread.

let sdn_config = SdnConfig {
node_id,
controller: if controller {
Some(ControllerPlaneCfg {
session,
bind_addrs: sdn_bind_addrs.clone(),
authorization: Arc::new(StaticKeyAuthorization::new(secret)),
handshake_builder: Arc::new(HandshakeBuilderXDA),
random: Box::new(OsRng),
services: vec![visualization.clone(), discovery.clone(), gateway.clone(), connector.clone()],
history: history.clone(),
})
} else {
None
},
tick_ms: 1000,
data: DataPlaneCfg {
worker_id: 0,
services: vec![visualization, discovery, gateway],
history,
},
};

(at line 194 we missed "connector")

This only occurred after we have some optimized by avoiding internal event re-router to controller then back to worker.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

@giangndm
Copy link
Contributor Author

giangndm commented Aug 7, 2024

@jibon57 This PR related with your feedback about missing room logs

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.87%. Comparing base (9b1403b) to head (4ff9155).

Files Patch % Lines
packages/media_runner/src/worker.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   40.87%   40.87%           
=======================================
  Files         153      153           
  Lines       16472    16472           
=======================================
  Hits         6733     6733           
  Misses       9739     9739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jibon57
Copy link
Contributor

jibon57 commented Aug 7, 2024

@giangndm if you could add feature to get list/number of active tracks will be helpful too. Different other info like current bandwidth usage (upload/download).

@giangndm
Copy link
Contributor Author

giangndm commented Aug 7, 2024

@jibon57 can you explain more in Discord channel or a Discussion Topic?

@giangndm giangndm marked this pull request as ready for review August 7, 2024 07:28
@giangndm giangndm merged commit 1155097 into 8xFF:master Aug 7, 2024
10 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the fix-missed-media-logs branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants