Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: route restart-ice to other media node if current down #410

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Aug 7, 2024

Pull Request

Description

This PR implement node fallback with restart-ice request for allowing reconnect to other node.

Re-route Flow:

  • If dest-node is same zone with gateway -> return Some(dest) if online
  • If dest-node is other zone -> find dest zone gateway and return Some(gateway_node) if available

If no dest found (node or gateway), then select from pool based on client IP

Related Issue

#383

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 35.89744% with 75 lines in your changes missing coverage. Please review.

Project coverage is 40.91%. Comparing base (faf69e2) to head (5844897).

Files Patch % Lines
bin/src/server/gateway/local_rpc_handler.rs 0.00% 34 Missing ⚠️
bin/src/server/gateway/dest_selector.rs 0.00% 29 Missing ⚠️
packages/media_gateway/src/store.rs 30.00% 7 Missing ⚠️
packages/media_gateway/src/store_service.rs 0.00% 4 Missing ⚠️
bin/src/server/gateway.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   40.87%   40.91%   +0.03%     
==========================================
  Files         153      154       +1     
  Lines       16472    16538      +66     
==========================================
+ Hits         6733     6766      +33     
- Misses       9739     9772      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review August 7, 2024 17:25
@giangndm giangndm merged commit 51dcb53 into 8xFF:master Aug 7, 2024
10 of 11 checks passed
@giangndm giangndm deleted the fix-send-restart-ice-to-other-node-if-current-down branch August 7, 2024 17:26
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
…down (8xFF#410)

* fixed: route restart-ice to other media node if current down

* fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant