Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: config zone id node id media port, get console lists #417

Merged

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Aug 8, 2024

Pull Request

Description

This PR updates the SDN configuration. Changed form u32 sdn-zone, node-id to

  • u24 sdn-zone-id: what every you chose for zone_id (but should be smallest as possible for routing efficiency)
  • u8 sdn-zone-node-id: from 0 to 255, which mean you have maximum 256 node in a single zones

Related Issue

#409

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

@giangndm giangndm linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 44.09449% with 71 lines in your changes missing coverage. Please review.

Project coverage is 40.75%. Comparing base (418e0e5) to head (c31d124).

Files Patch % Lines
bin/src/server/console/storage.rs 52.17% 22 Missing ⚠️
bin/src/main.rs 0.00% 20 Missing ⚠️
bin/src/http/api_console/cluster.rs 0.00% 8 Missing ⚠️
bin/src/server/media.rs 0.00% 5 Missing ⚠️
packages/media_gateway/src/store.rs 63.63% 4 Missing ⚠️
packages/media_gateway/src/store/service.rs 88.00% 3 Missing ⚠️
packages/protocol/src/cluster.rs 50.00% 3 Missing ⚠️
packages/media_gateway/src/store_service.rs 0.00% 2 Missing ⚠️
packages/protocol/src/gateway.rs 0.00% 2 Missing ⚠️
packages/media_runner/src/worker.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   40.88%   40.75%   -0.13%     
==========================================
  Files         154      153       -1     
  Lines       16550    16597      +47     
==========================================
- Hits         6766     6764       -2     
- Misses       9784     9833      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review August 9, 2024 02:45
@giangndm giangndm merged commit 597ab58 into 8xFF:master Aug 9, 2024
11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
)

* refactor node-id, zone-id and sdn-port media-port for better configuring

* refactor with zone-id, added consoles list api

* update docs for new sdn-zone-id, sdn-zone-idx config

* fix clippy

* change term: sdn-zone-idx to sdn-zone-node-id
@giangndm giangndm deleted the refactor-config-zone-id-node-id-media-port branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better cluster config
1 participant