Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: endpoint internal clean up crash #447

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Oct 27, 2024

Pull Request

Description

This PR fix #440

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 232 lines in your changes missing coverage. Please review.

Project coverage is 41.51%. Comparing base (4746d6b) to head (3c26709).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/media_core/src/endpoint/internal/remote_track.rs 46.43% 173 Missing ⚠️
bin/src/http.rs 0.00% 32 Missing ⚠️
packages/media_core/src/endpoint/internal.rs 35.29% 11 Missing ⚠️
bin/src/http/api_metrics.rs 0.00% 4 Missing ⚠️
packages/media_utils/src/count.rs 90.00% 4 Missing ⚠️
bin/src/server/media.rs 0.00% 3 Missing ⚠️
packages/transport_rtpengine/src/transport.rs 0.00% 2 Missing ⚠️
packages/media_core/src/endpoint.rs 0.00% 1 Missing ⚠️
...es/media_core/src/endpoint/internal/local_track.rs 0.00% 1 Missing ⚠️
packages/transport_webrtc/src/transport.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   41.37%   41.51%   +0.13%     
==========================================
  Files         165      167       +2     
  Lines       18154    18460     +306     
==========================================
+ Hits         7512     7664     +152     
- Misses      10642    10796     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review November 4, 2024 07:35
@giangndm giangndm merged commit 98ec0bd into 8xFF:master Nov 4, 2024
11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
* fix: remote track fired Stopped event but queue still has data bug

* clear internal tracks on disconnect

* added metrics for tracking live objects

* fix build error

* missing clear tracks_id map in EndpointInternal
@giangndm giangndm deleted the fix-core-clean-up-crash branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: server crash on endpoint destroyed
1 participant