Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash assert on destroy #449

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Nov 8, 2024

Description

This PR refactor resource clean-up strategy with new sans-io-runtime for fixing crash on destroy issue

Related Issue

#440

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 30.85250% with 511 lines in your changes missing coverage. Please review.

Project coverage is 34.36%. Comparing base (c563f2d) to head (b069ddc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/media_core/src/endpoint/internal/remote_track.rs 40.28% 83 Missing ⚠️
packages/media_utils/src/state.rs 0.00% 80 Missing ⚠️
packages/media_core/src/endpoint/internal.rs 17.02% 39 Missing ⚠️
packages/transport_webrtc/src/transport/webrtc.rs 0.00% 29 Missing ⚠️
...ackages/media_core/src/cluster/room/audio_mixer.rs 44.44% 25 Missing ⚠️
packages/transport_rtpengine/src/transport.rs 0.00% 25 Missing ⚠️
...es/media_core/src/endpoint/internal/local_track.rs 0.00% 19 Missing ⚠️
packages/media_connector/src/agent_service.rs 0.00% 17 Missing ⚠️
packages/media_connector/src/handler_service.rs 0.00% 17 Missing ⚠️
packages/media_gateway/src/agent_service.rs 0.00% 17 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   40.91%   34.36%   -6.56%     
==========================================
  Files         175      176       +1     
  Lines       19071    17474    -1597     
==========================================
- Hits         7803     6005    -1798     
- Misses      11268    11469     +201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review November 13, 2024 02:20
@giangndm giangndm merged commit 436d7ea into 8xFF:master Nov 13, 2024
9 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
* new resource clean strategy with new sans-io-runtime lib

* avoid shutdown loop when rtp timeout with rtpengine
@giangndm giangndm deleted the fix-crash-assert-on-destroy branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant