Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add duration_ms to compose record result #451

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

giangndm
Copy link
Contributor

Description

This PR add duration_ms to record compose output

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

@giangndm giangndm marked this pull request as ready for review November 13, 2024 02:52
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 34.35%. Comparing base (c563f2d) to head (63a6934).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
packages/media_record/src/convert/composer.rs 0.00% 7 Missing ⚠️
packages/media_record/bin/convert_record_worker.rs 0.00% 4 Missing ⚠️
...kages/media_record/src/convert/codec/vpx_writer.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   40.91%   34.35%   -6.57%     
==========================================
  Files         175      176       +1     
  Lines       19071    17486    -1585     
==========================================
- Hits         7803     6007    -1796     
- Misses      11268    11479     +211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm enabled auto-merge November 13, 2024 03:11
@giangndm giangndm disabled auto-merge November 13, 2024 03:14
@giangndm giangndm merged commit f61ecd2 into 8xFF:master Nov 13, 2024
9 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the feat-record-compose-duration branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant