Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to manual2 discovery #486

Merged
merged 8 commits into from
Feb 8, 2025

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Feb 6, 2025

Pull Request

Description

This PR switch to manual2 discovery feature in atm0s-sdn. This feature for allowing better node discovery in complex cluster topology

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 128 lines in your changes missing coverage. Please review.

Project coverage is 35.90%. Comparing base (41cf961) to head (2c428a1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
bin/src/seeds.rs 0.00% 27 Missing ⚠️
bin/src/server/gateway.rs 0.00% 26 Missing ⚠️
bin/src/server/media.rs 0.00% 26 Missing ⚠️
bin/src/server/console.rs 0.00% 23 Missing ⚠️
bin/src/server/connector.rs 0.00% 16 Missing ⚠️
bin/src/server/standalone.rs 0.00% 4 Missing ⚠️
bin/src/main.rs 0.00% 2 Missing ⚠️
packages/media_gateway/src/agent_service.rs 0.00% 2 Missing ⚠️
packages/media_runner/src/worker.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   36.05%   35.90%   -0.16%     
==========================================
  Files         176      175       -1     
  Lines       18206    18238      +32     
==========================================
- Hits         6564     6548      -16     
- Misses      11642    11690      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit 2f7e6a5 into 8xFF:master Feb 8, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant