Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong typos cause publish error #93

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

giangndm
Copy link
Contributor

No description provided.

@@ -23,7 +23,7 @@
pub use bitrate_limiter::BitrateLimiterType;

#[derive(Debug, PartialEq, Eq)]
pub enum MediaEndpointInteralEvent {
pub enum MediaEndpointInternalEvent {

Check warning

Code scanning / clippy

variants `SubscribePeer` and `UnsubscribePeer` are never constructed

variants `SubscribePeer` and `UnsubscribePeer` are never constructed
@@ -49,9 +49,9 @@
bitrate_limiter: bitrate_limiter::BitrateLimiter,
}

impl MediaEndpointInteral {
impl MediaEndpointInternal {

Check warning

Code scanning / clippy

method `push_cluster` is never used

method `push_cluster` is never used
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (323236a) 54.20% compared to head (ea5d0be) 54.20%.

Files Patch % Lines
packages/endpoint/src/endpoint_wrap.rs 0.00% 3 Missing ⚠️
servers/media/src/server.rs 0.00% 3 Missing ⚠️
packages/endpoint/src/endpoint_wrap/internal.rs 92.30% 1 Missing ⚠️
servers/media/src/main.rs 0.00% 1 Missing ⚠️
transports/webrtc/src/transport.rs 0.00% 1 Missing ⚠️
...nsports/webrtc/src/transport/rtp_packet_convert.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files         106      106           
  Lines        9488     9488           
=======================================
  Hits         5143     5143           
  Misses       4345     4345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review November 24, 2023 01:17
@giangndm giangndm merged commit f146ac6 into 8xFF:master Nov 24, 2023
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
@giangndm giangndm deleted the fix-wrong-typos-cannot-publish branch June 6, 2024 00:44
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant