Allow multiple CIDR ranges in build_netmap when using LAN shorthands
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akp <abi@tdpain.net>
codemicro
changed the title
build_netmap when using prebuilt shorthandsbuild_netmap when using LAN shorthands
|
Nice! thanks for catching and fixing this 😁 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use LAN shorthands when specifying custom CIDR ranges. For example, in the situation where you want to allow connections from both the various local networking places and from Tailscale, you would want to do:
but this currently does not work and instead causes copyparty to fail to start.
This is because shorthands are currently detected by comparison to the whole comma-separated string - this PR moves shorthand expansion to after the parsing step to make the above example work as expected.
This PR complies with the DCO; https://developercertificate.org/
:)