-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/parcelhoc updates #121
Merged
dxinteractive
merged 18 commits into
release/playful-python
from
feature/parcelhoc-updates
Oct 22, 2018
Merged
Feature/parcelhoc updates #121
dxinteractive
merged 18 commits into
release/playful-python
from
feature/parcelhoc-updates
Oct 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les-compat to use this new version with < react@v16.3.0
…dataparcels into feature/parcelhoc-updates
…ag/dataparcels into feature/parcelhoc-updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataparcels
Parcel.batchAndReturn
only on top level parcelsbatch()
but returns the parcel instead of callinghandleChange
react-dataparcels
ParcelHoc config.initialValue
is now calledParcelHoc config.valueFromProps
ParcelHoc
now usesgetDerivedStateFromProps
. Use https://github.com/reactjs/react-lifecycles-compat if you're on a React version earlier than 16.3.0ParcelHoc config.shouldParcelUpdateFromProps
which allows a ParcelHoc to replace its parcel's contents based on prop changes. At this point the only option is to completely replace all of the parcels contents and delete all key and meta information, depending on the outcome of a boolean test. In future there will be more options to allow partial changes, and to allow key and meta data to be retained.